[GLUTEN-6470][CH]Fix Task not serializable error when inserting mergetree data #6473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
…tree data When inserting mergetree data, it occurs the Task not serializable error in some cases. RC: In the Delta, the options of the `DeltaOptions` is a `CaseInsensitiveMap`, if calling the api `filterKeys()` of the `CaseInsensitiveMap`, it may become not serializable, so lead to this error. Close apache#6470.
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
baibaichen
reviewed
Jul 17, 2024
| @@ -39,7 +39,7 @@ abstract class Affinity(val manager: AffinityManager) extends LogLevelUtil with | |||
| filePaths: Array[String], | |||
| preferredLocations: Array[String]): Array[String] = { | |||
| if (shouldUseSoftAffinity(filePaths, preferredLocations)) { | |||
| internalGetHostLocations(filePaths.min) | |||
| internalGetHostLocations(filePaths(0)) | |||
There was a problem hiding this comment.
Is this modification related to this issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When inserting mergetree data, it occurs the Task not serializable error in some cases.
RC:
In the Delta, the options of the
DeltaOptionsis aCaseInsensitiveMap, if calling the apifilterKeys()of theCaseInsensitiveMap, it may become not serializable, so lead to this error.Close #6470.
(Fixes: #6470)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)